Review branch for updating to v0.30.13#13
Closed
bnavetta wants to merge 8 commits into
Closed
Conversation
* Exit instead of panicking on X11 connection loss. * formatting * formatting 2, electric boogaloo
Winit on web has a bug where the EventLoopProxy will immediately call handlers for a custom event in send_event instead of scheduling it for the next event tick. This causes double-borrows of our MutableAppContext, which hard crashes the app. This is a bandaid fix which pushes those calls on the microtask queue instead.
This reverts commit 1813f60. This is fixed upstream.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+241
to
+253
| name: Minimize JavaScript | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: taiki-e/checkout-action@v1 | ||
| - name: Install SWC | ||
| run: sudo npm i -g @swc/cli | ||
| - name: Run SWC | ||
| run: | | ||
| swc src/platform_impl/web/web_sys/worker.js -o src/platform_impl/web/web_sys/worker.min.js | ||
| - name: Check for diff | ||
| run: | | ||
| [[ -z $(git status -s) ]] |
alokedesai
reviewed
May 18, 2026
Member
alokedesai
left a comment
alokedesai
left a comment
There was a problem hiding this comment.
LGTM. Good to force push 🫡
Author
|
Force-pushed to |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is our winit
v0.30.xpatch set, rebased fromv0.30.1tov0.30.13.